[PATCH] D45210: [New-PM] Lift Scop Pipeline to CGSCC-level

Lukas Böhm via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 5 00:37:15 PDT 2018


lksbhm added inline comments.


================
Comment at: include/polly/ScopPass.h:278
   ScopPassT Pass;
-}; // namespace polly
+};
 
----------------
Meinersbur wrote:
> philip.pfaffe wrote:
> > unrelated change
> The comments are added by `clang-format`, `make check-polly` probably already complained about format changes.
This is the only remark I didn't do any changes for with the latest update. Since the closing brace is for the `CGSCCToScopPassAdaptor`, the "namespace" comment is clearly misplaced. I ran the `polly-update-format` target with a `clang-format` built half an hour ago and it didn't re-insert the comment. However, `RegisterPasses.cpp` would get it's corresponding header moved above the other includes. I assume this is an unrelated change as well, though, so I didn't put it in the diff.


Repository:
  rPLO Polly

https://reviews.llvm.org/D45210





More information about the llvm-commits mailing list