[PATCH] D44812: Remove MachineLoopInfo dependency from AsmPrinter.

[Renato Golin via Phabricator via llvm-commits]

rengolin accepted this revision.
rengolin added a comment.
This revision is now accepted and ready to land.

I had seen the first version of this patch and thought it confusing, so refrained from reviewing (too broad context), but this version is much clearer now, and I can see it as straightforward benefit.

I'll tentatively approve waiting for another review for a day or so?

Thanks!



================
Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:2774
+
+    assert(MLI != nullptr && "MachineLoopInfo should has been computed");
+    emitBasicBlockLoopComments(MBB, MLI, *this);
----------------
mzolotukhin wrote:
> rengolin wrote:
> > Wait, isn't this only set if `isVerbose`?
> Yes, and here it's also under this condition. Am I missing something?
D'oh! Sorry, it is. Late night patch review. 


Repository:
  rL LLVM

https://reviews.llvm.org/D44812