[PATCH] D45146: [x86] Introduce a pass to begin more systematically fixing PR36028 and similar issues.

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/X86/X86FlagsCopyLowering.cpp:378
+      // this complex case here.
+      DEBUG(dbgs() << "ERROR: Encountered unexpected def of an eflags copy: "; CopyDefI.dump());
+      report_fatal_error("Cannot lower EFLAGS copy unless it is defined in turn by a copy!");
----------------
Is this longer than 80 columns?


================
Comment at: llvm/lib/Target/X86/X86FlagsCopyLowering.cpp:500
+        dbgs() << "----\n"
+               << "ERROR: Cannot lower this EFLAGS copy !\n";
+      });
----------------
Nit - extra space before the exclamation mark.


================
Comment at: llvm/lib/Target/X86/X86FlagsCopyLowering.cpp:589
+  // also allow us to select a shorter encoding of `testb %reg, %reg` when that
+  // would be equivalent.
+  auto TestI =
----------------
Are we clever enough to make that conversion to the shorter encoding?


Repository:
  rL LLVM

https://reviews.llvm.org/D45146