[PATCH] D44257: [MemorySSAUpdater] Mark non-trivial Phi for not to optimize

[Daniel Berlin via llvm-commits]

On Wed, Apr 4, 2018 at 7:28 PM, Z. Zheng via Phabricator <
reviews at reviews.llvm.org> wrote:

> zzheng marked 2 inline comments as done.
> zzheng added a comment.
>
> > Just one nit (inline) and a general question: is this new set meant to
> persist across multiple updates, should the `erase` in `fixupDefs` be
> taking care of everything added in a given query, or should we be clearing
> it at some point?
>
> > (If the answer is "the middle one," would it be easy to assert that the
> def is empty somewhere?)
>
> At least two GVN-hoist test cases need NonOptPhis be cleared.


Right, because we don't necessarily need to fixup all users.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180404/5e0e745a/attachment.html>