[PATCH] D45299: API to update MemorySSA for cloned blocks.

[Alina Sbirlea via Phabricator via llvm-commits]

asbirlea added a comment.

First concern is duplicating functionality already present in MemorySSA. I honestly don't understand everything well enough, so it's possible there are chunks that can be factored out from existing methods and the ones in this patch.

Second concern is the best way to expose an update API. Until now, each update call pretty much assumed valid MemorySSA before and after the call. I'm adding APIs where it's known that  MemorySSA is broken before the call.

Happy to get nitpicking after the high-level view, just to avoid the distraction.
But if you see something that bugs you now, please feel free to nitpick so we get *that* distraction out of the way :).

Also note that, while the stack of 3 patches doesn't crash any tests, it's not necessarily error-free. It should however give a good view of the end goal.


Repository:
  rL LLVM

https://reviews.llvm.org/D45299