[PATCH] D45239: AArch64: Implement support for the shadowcallstack attribute.

[Evgenii Stepanov via Phabricator via llvm-commits]

eugenis added inline comments.


================
Comment at: clang/docs/ShadowCallStack.rst:12
 ShadowCallStack is an **experimental** instrumentation pass, currently only
 implemented for x86_64, that protects programs against return address
 overwrites (e.g. stack buffer overflows.) It works by saving a function's return
----------------
vlad.tsyrklevich wrote:
> Should also mention aarch64 here.
needs update


================
Comment at: llvm/lib/Target/AArch64/AArch64FrameLowering.cpp:1153
+        report_fatal_error("Must reserve x18 to use shadow call stack");
+      NeedSCSProlog = true;
+    }
----------------
That's way too cryptic, please call it NeedShadowCallStackProlog or something similar.


https://reviews.llvm.org/D45239