[PATCH] D45210: [New-PM] Lift Scop Pipeline to CGSCC-level

[Philip Pfaffe via Phabricator via llvm-commits]

philip.pfaffe added inline comments.


================
Comment at: include/polly/ScopPass.h:36
     AnalysisManager<Scop, ScopStandardAnalysisResults &>;
+
 using ScopAnalysisManagerFunctionProxy =
----------------
Unrelated change


================
Comment at: include/polly/ScopPass.h:53
+/// Implementation of ScopAnalysisManagerFunctionProxy
+// @{
 template <>
----------------
Should have three slashes


================
Comment at: include/polly/ScopPass.h:181
 private:
-  bool runOnRegion(Region *R, RGPassManager &RGM) override;
+  bool runOnRegion(Region *R, RGPassManager &RGM) final override;
   void print(raw_ostream &OS, const Module *) const override;
----------------
Unrelated change


================
Comment at: include/polly/ScopPass.h:259
+        PA.intersect(std::move(PassPA));
+        if (Updater.invalidateCurrentScop()) {
+          SI.recompute();
----------------
No curly braces required here


================
Comment at: include/polly/ScopPass.h:278
   ScopPassT Pass;
-}; // namespace polly
+};
 
----------------
unrelated change


================
Comment at: lib/Analysis/ScopPass.cpp:15
 #include "polly/ScopPass.h"
-#include "polly/ScopInfo.h"
 
----------------
This shouldn't be removed


================
Comment at: lib/Support/RegisterPasses.cpp:717
 
+  // FIXME There is no cgscc-level registerVectorizerStartEPCallback as
+  // of now
----------------
Irrelevant


Repository:
  rPLO Polly

https://reviews.llvm.org/D45210