[PATCH] D45261: [ELF] - Allow LLD to produce file symbols.

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added a comment.

In https://reviews.llvm.org/D45261#1057057, @espindola wrote:

> LGTM, now we just have to sort them :-)


Don't we need to do that at the same time as emitting them? The generic ABI says:

> STT_FILE
>  Conventionally, the symbol's name gives the name of the source file associated with the object file. A file symbol has STB_LOCAL binding, its section index is SHN_ABS, and it precedes the other STB_LOCAL symbols for the file, if it is present.


https://reviews.llvm.org/D45261