[PATCH] D45260: COFF: Layout sections in the same order as link.exe

[Hans Wennborg via Phabricator via llvm-commits]

hans added inline comments.


================
Comment at: COFF/Writer.cpp:660-662
+      .Case(".rsrc", INT_MAX - 1)
+      .Case(".reloc", INT_MAX)
+      .Default(INT_MAX / 2); // Default to somewhere in the middle.
----------------
ruiu wrote:
> This is a nit but I'd perhaps use 99, 100 and 50 or something like that for these numbers instead of super large numbers.
Will do.


================
Comment at: COFF/Writer.cpp:661
+      .Case(".rsrc", INT_MAX - 1)
+      .Case(".reloc", INT_MAX)
+      .Default(INT_MAX / 2); // Default to somewhere in the middle.
----------------
pcc wrote:
> Have you confirmed that UpdateResource updates the `.reloc` address in the data directory if it is moved?
Let me check..


https://reviews.llvm.org/D45260