[PATCH] D45146: [x86] Introduce a pass to begin more systematically fixing PR36028 and similar issues.
Reid Kleckner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 4 11:22:44 PDT 2018
rnk added inline comments.
================
Comment at: llvm/lib/Target/X86/X86FlagsCopyLowering.cpp:615
+ Cond = X86::COND_B; // CF == 1
+ Addend = 127;
+ break;
----------------
craig.topper wrote:
> I think these Addend values are backwards. 255 would work for carry, and 127 would work for overflow
I confirmed this with assembly. You might want to do some multi-precision ADDC execution tests locally to validate the change after fixing this.
Repository:
rL LLVM
https://reviews.llvm.org/D45146
More information about the llvm-commits
mailing list