[PATCH] D45158: [ELF] - X86_64: don't allow 8/16 bit dynamic relocations.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 4 04:49:13 PDT 2018


grimar added a comment.

In https://reviews.llvm.org/D45158#1055052, @espindola wrote:

> LGTM
>
> Two suggestion for followups:
>
> Rename isPicRel. This is not really about being position independent, it is about the dynamic linker supporting these.
>  Use a while list instead.


Thanks for the suggestions! I prepared https://reviews.llvm.org/D45248 and https://reviews.llvm.org/D45252 to address them.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D45158





More information about the llvm-commits mailing list