[PATCH] D44464: allow custom OptBisect classes set to LLVMContext

[Fedor Sergeev via Phabricator via llvm-commits]

fedor.sergeev added a comment.

a few nits, LGTM as soon as those are corrected.



================
Comment at: include/llvm/IR/LLVMContext.h:325
+  ///
+  /// The lifetime of the object must be guaranteed to extend as long as the
+  /// the LLVMContext is used by pass manager.
----------------
must be guaranteed by the caller


================
Comment at: include/llvm/IR/LLVMContext.h:326
+  /// The lifetime of the object must be guaranteed to extend as long as the
+  /// the LLVMContext is used by pass manager.
+  void setOptPassGate(OptPassGate&);
----------------
1. delete extra 'the'
2. I dont like 'pass manager' here. LLVMContext is not a property of pass manager. Can we say "used by compilation"?


https://reviews.llvm.org/D44464