[PATCH] D43820: [ELF] - Check that output sections fit in address space.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 4 02:27:29 PDT 2018


grimar added inline comments.


================
Comment at: ELF/Writer.cpp:2071
 // ranges and the virtual address ranges don't overlap
 template <class ELFT> void Writer<ELFT>::checkSectionOverlap() {
+  // First, check that section's VAs fit in available address space for target.
----------------
ruiu wrote:
> You should have changed the name of this function because it does more than checking section overlaps.
I renamed it to `checkSections`, it matches the command line option name. Does it sound fine?


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D43820





More information about the llvm-commits mailing list