[PATCH] D45195: Add --check-library-dependency to maintain compatibility with other linkers

[David Blaikie via llvm-commits]

On Tue, Apr 3, 2018 at 6:20 PM Rafael Avila de Espindola via Phabricator <
reviews at reviews.llvm.org> wrote:

> espindola added a comment.
>
> The option and general algorithm makes sense to me.
>
> I am just not sure about the name since cyclic dependencies are still
> supported with --start-group/--end-group for example.
>
> BTW, I think this is a conservative heuristic since it would warn on
> "foo.a --start-group bar.a foo.a --end-group" if bar.a fetches a member of
> foo.a. That is probably fine.
>

Yeah, the fact that this would produce a warning for code that a
traditional unix linker would succeed at (when repeating libs on a link
line to resolve those cycles) is a bit unfortunate, but at least not
something I care about for my own uses, I don't think (I mean, I haven't
looked at LLVM's build, but I doubt it uses this
specify-a-library-more-than-once trick)



>
> Taking a look at the implementation now.
>
>
> https://reviews.llvm.org/D45195
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180404/710242cf/attachment.html>