[PATCH] D44257: [MemorySSAUpdater] Mark non-trivial Phi for not to optimize

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a reviewer: george.burgess.iv.
efriedma added a comment.

Please commit the spelling corrections in lib/Analysis/MemorySSA.cpp separately.

This looks right, but I'm not that familiar with the algorithm; hopefully Daniel will chime in.



================
Comment at: include/llvm/Analysis/MemorySSAUpdater.h:63
   SmallPtrSet<BasicBlock *, 8> VisitedBlocks;
+  SmallPtrSet<MemoryPhi *, 8> NonOptPhis;
 
----------------
Can you use `AssertingVH<MemoryPHI>` here?  I don't think you can get any dangling pointers with your algorithm, but it's nice to add some extra checks.


Repository:
  rL LLVM

https://reviews.llvm.org/D44257