[PATCH] D45119: [RISCV] Override EmitToStreamer in RISCVAsmPrinter to handle missed compression opportunities

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 3 17:40:31 PDT 2018


efriedma added a comment.

Oh, I didn't realize there was another codepath when I suggested RISCVAsmPrinter::EmitInstruction.

It's generally a good idea to avoid virtual functions where possible... in this context, I think it would work correctly if you just shadow the function?


https://reviews.llvm.org/D45119





More information about the llvm-commits mailing list