[PATCH] D44400: Fix LLVM IR check lines in utils/update_cc_test_checks.py

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 3 14:10:08 PDT 2018


RKSimon added a comment.

In https://reviews.llvm.org/D44400#1055628, @mike.dvoretsky wrote:

> Could somebody here please clarify what's happening with test/CodeGen/X86/avx2-intrinsics-x86.ll? Before recent changes to the utils (https://reviews.llvm.org/D42654, https://reviews.llvm.org/D42805, this) it had a pattern ret{{l|q}} with which the same blocks of checks corresponded to 2 run lines each. Now the utils produce separate checks for those lines. Was this intended? If so, please update the tests after your changes, otherwise it may be an issue with the utils.


Some x86 test files were generated with the '--x86_extra_scrub' flag - as part of an ongoing attempt to merge 32/64 bit checks that only differ with the retl/retq - see PR35003


Repository:
  rL LLVM

https://reviews.llvm.org/D44400





More information about the llvm-commits mailing list