[PATCH] D45225: [WIP] Add IR function attributes to represent codegen optimization level

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 3 13:00:25 PDT 2018


efriedma added inline comments.


================
Comment at: lib/IR/Module.cpp:91
 
+CodeGenOpt::Level Module::getCodeGenOptLevel() const {
+  if (FunctionList.empty())
----------------
This doesn't make any sense.  If it's a per-function attribute, we should be computing it per function.  The maximum level set on any function doesn't have any useful meaning.


https://reviews.llvm.org/D45225





More information about the llvm-commits mailing list