[PATCH] D45221: [coroutines] Respect alloca alignment requirements when building coroutine frame

Brian Gesiak via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 3 13:00:24 PDT 2018


modocache accepted this revision.
modocache added a comment.
This revision is now accepted and ready to land.

Thank you, @GorNishanov, this is excellent! I've pulled this down and confirmed it fixes some nasty errors in a codebase I work on, related to this usage of `std::aligned_storage` <https://github.com/facebook/folly/blob/3cec1c6b4ccfa4b80effad376f6321ce9b70cec1/folly/Function.h#L253>. The problem also reproduced with this much smaller example: https://reviews.llvm.org/P8076 -- and I've confirmed this change of yours fixes that, too. So, thank you!

The code itself looks good to me!


https://reviews.llvm.org/D45221





More information about the llvm-commits mailing list