[PATCH] D45224: [SymbolFilePDB] Add support for resolving variable symbols

[Aaron Smith via Phabricator via llvm-commits]

asmith created this revision.
asmith added reviewers: rnk, zturner, lldb-commits.
Herald added subscribers: llvm-commits, JDevlieghere, aprantl.

Implement FindGlobalVariables and ParseVariableContext methods.

Compile unit information is necessary for resolving variable context, however some PDB symbols do not have this information. For now an empty DWARFExpression is used to construct a lldb::Variable instance with the limitation that using lldb to lookup the value of a global or local variable is not available.

This commit may slow down lit/SymbolFile/PDB/compilands.test since the test includes MS specific modules that spend more time parsing variables.


Repository:
  rL LLVM

https://reviews.llvm.org/D45224

Files:
  lit/SymbolFile/PDB/Inputs/VariablesTest.cpp
  lit/SymbolFile/PDB/variables.test
  source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp
  source/Plugins/SymbolFile/PDB/SymbolFilePDB.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D45224.140842.patch
Type: text/x-patch
Size: 16439 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180403/b830f289/attachment.bin>