[PATCH] D45122: [DebugInfo] Add a new DI flag to record if a C++ record is a trivial type

David Blaikie via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 3 11:35:28 PDT 2018


This still doesn't /sound/ right to me - the triviality of a class doesn't
seem like it would correctly allow you to deduce the triviality of specific
special members? Because the the class would only be considered trivial if
all the special members are trivial, probably?

I suspect the CxxReturnUdt might be related to the PassByValue/Reference
feature we already have for DWARF.

For example does MSVC put CxxReturnUdt on return types where they have a
non-trivial default ctor, but a trivial copy ctor? or other variations like
that.

Reid/Zach - you two looked at this sort of thing & have a better sense of
what each of these flags represent? (maybe ideas about what we should do
for types marked with Clang's [[trivial_abi]] attribute (obviously wouldn't
be interoperable with code compiled with MSVC since it doesn't support the
attribute - but still be good to know how to describe the type to the
debugger)?

On Tue, Apr 3, 2018 at 11:13 AM Aaron Smith via Phabricator <
reviews at reviews.llvm.org> wrote:

> asmith added a comment.
>
> https://reviews.llvm.org/D44406 is not completely the same as this one
> yes. Did you look at the
> MSVC examples in https://reviews.llvm.org/D45123?
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D45122
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180403/0796c718/attachment.html>


More information about the llvm-commits mailing list