[PATCH] D45083: [ELF] - Eliminate Lazy class.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 3 09:49:40 PDT 2018


ruiu accepted this revision.
ruiu added a comment.

LGTM



================
Comment at: ELF/Driver.cpp:1091-1100
+    if (Symbol *Sym = Symtab->find(S))
+      if (InputFile *F = Symtab->fetchIfLazy(Sym))
+        Symtab->addFile<ELFT>(F);
 
   // If an entry symbol is in a static archive, pull out that file now
   // to complete the symbol table. After this, no new names except a
   // few linker-synthesized ones will be added to the symbol table.
----------------
This is a bit worse than before, but I'll fix this after you commit it.


================
Comment at: ELF/SymbolTable.cpp:583
+    return L->fetch();
+  else if (LazyObject *L = dyn_cast<LazyObject>(Sym))
+    return cast<LazyObjFile>(L->File)->fetch();
----------------
Remove `else`


https://reviews.llvm.org/D45083





More information about the llvm-commits mailing list