[PATCH] D44560: [DWARF] Rework debug line parsing to use llvm::Error and callbacks

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere added a comment.

In https://reviews.llvm.org/D44560#1055714, @dblaikie wrote:

> I was picturing the parser being the thing that exposes the iterator - so
>  it would be an internal detail & wouldn't really warrant an extra Error
>  type - but I haven't thought about it too hard & maybe that doesn't make
>  sense?


The way the code is currently structured, `Parse` initializes the object on which you call it. What you say makes a lot of sense to have in DWARFContext, or alternatively in an abstraction between the two. Still, with the iterator you don't know what the reason is you don't have a line table, which I think was the motivation for this patch (to expose this to LLD).


Repository:
  rL LLVM

https://reviews.llvm.org/D44560