[PATCH] D44560: [DWARF] Rework debug line parsing to use llvm::Error and callbacks

Jonas Devlieghere via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 3 08:33:14 PDT 2018


JDevlieghere added a comment.

In https://reviews.llvm.org/D44560#1055708, @dblaikie wrote:

> I'm still a bit undecided about new Error types here - I think exposing an
>  iterator (or iterator-like thing) rather than special changes to the offset
>  or an error kind the user checks to see whether to iterate might be better?


I agree, but (unless I misunderstand) that's on another level, right? We'd still need to communicate from the parser whether we can parse the next LT, i.e. if there's going to be a next iterator?


Repository:
  rL LLVM

https://reviews.llvm.org/D44560





More information about the llvm-commits mailing list