[PATCH] D45106: [Build] Use LIBXML2_LIBRARIES from find_package

Pavel Labath via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 3 01:46:36 PDT 2018


labath added a comment.

I think you'll run into issues if you try to land this patch. I tried to do the same thing with zlib (see r319751 and related commits), but I had to roll it back because it broke things for a lot of people. Basically, the issue is we have code (e.g., `llvm-config --system-libs`) which assumes you can just paste "-l" in front of the system_libs libraries and get a valid linker line. This works only if system_libs is a list of bare lib names (and not a full file path).

I wish we had a better story for controlling the link behavior (I'm particularly interested in forcing static against a static library, when both static&dynamic libs are present), but right now I don't see how we could achieve that (without a big refactor).


Repository:
  rL LLVM

https://reviews.llvm.org/D45106





More information about the llvm-commits mailing list