[PATCH] D45189: [MachineOutliner][AArch64] Keep track of functions that use a red zone in AArch64MachineFunctionInfo and use that instead of checking for noredzone in the MachineOutliner

Francis Visoiu Mistrih via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 3 01:35:02 PDT 2018


thegameg added inline comments.


================
Comment at: lib/Target/AArch64/AArch64MachineFunctionInfo.h:94
+  /// True when the function uses a red zone.
+  bool UsesRedZone = false;
+
----------------
Since this is available only after PEI, I wonder if it wouldn't be safer to initialize `UsesRedZone` to `!F.hasFnAttribute(Attribute::NoRedZone)`. That way if the function is called before PEI we use the attribute, and after PEI we overwrite this.


https://reviews.llvm.org/D45189





More information about the llvm-commits mailing list