[PATCH] D44001: [SCEV] Prove implications for SCEVUnknown Phis

[Max Kazantsev via Phabricator via llvm-commits]

mkazantsev marked 5 inline comments as done.
mkazantsev added inline comments.


================
Comment at: lib/Analysis/ScalarEvolution.cpp:9643
+  } else {
+    // In all other cases go over inputs of LHS and compare each of them to RHS,
+    // the predicate is true for (LHS, RHS) if it is true for all such pairs.
----------------
anna wrote:
> Could you state here: `LHS is phi and RHS is non-phi`. It's obvious when looking at above code and the swapping, but easier when seeing this as a standalone third case.
It is not utterly correct: RHS can be a Phi either SCEVUnknown or AddRec, but from different block than LPhi.


https://reviews.llvm.org/D44001