[PATCH] D45197: Change which file we print when a symbol cannot be ordered

[Rafael Avila de Espindola via Phabricator via llvm-commits]

espindola added inline comments.


================
Comment at: ELF/Writer.cpp:1055
       SymbolOrderEntry &Ent = It->second;
+      if (Ent.Present && !Sym->isLocal())
+        continue;
----------------
ruiu wrote:
> This is perhaps better?
> 
>   if (File != Sym->File)
The problem with that is that we would not warn on shared symbols since we don't iterate over SharedSymbols.

Let me try a variation.


https://reviews.llvm.org/D45197