[PATCH] D45192: [lld] fix data race in ELF/ICF.cpp
Rui Ueyama via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 2 19:41:44 PDT 2018
ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: lld/ELF/ICF.cpp:399
+ Boundaries[NumShards] = Sections.size();
+ parallelForEachN(1, NumShards, [&](size_t I) {
+ Boundaries[I] = findBoundary((I - 1) * Step, Sections.size());
----------------
This looks a bit too dense, so please insert a newline here
================
Comment at: lld/ELF/ICF.cpp:402
+ });
+ parallelForEachN(1, NumShards + 1, [&](size_t I) {
+ if (Boundaries[I - 1] < Boundaries[I])
----------------
and here
https://reviews.llvm.org/D45192
More information about the llvm-commits
mailing list