[PATCH] D45180: libcalls must check for "RtLibUseGOT" metadata during simplification
Rafael Avila de Espindola via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 2 17:57:26 PDT 2018
espindola requested changes to this revision.
espindola added a comment.
This revision now requires changes to proceed.
>> Given that we have nonlazybind on each GV, if we are replacing the printf GV with the puts GV we should copy nonlazybind from one to the other.
>
> This is not happening for any attribute of printf right now and some attributes simply cannot be copied over so this doesn't seem easy to do.
That just means you found the first case where we have to do it. Being hard is also not a reason for doing the wrong thing.
https://reviews.llvm.org/D45180
More information about the llvm-commits
mailing list