[PATCH] D45180: libcalls must check for "RtLibUseGOT" metadata during simplification

[Rafael Avila de Espindola via Phabricator via llvm-commits]

espindola added a comment.

In https://reviews.llvm.org/D45180#1055103, @tmsriram wrote:

> In https://reviews.llvm.org/D45180#1055100, @espindola wrote:
>
> > I am not sure I understand. Shouldn't this just copy nonlazybind from printf to puts?
>
>
> I didn't see that happen anywhere,  inferLibFuncAttribues is where the attributes are added to the simplified function.


So maybe this is the wrong place to make the change?

Given that we have nonlazybind on each GV, if we are replacing the printf GV with the puts GV we should copy nonlazybind from one to the other.

Another option that would be consistent is to just not have nonlazybind and always use RtLibUseGOT in codegen.


https://reviews.llvm.org/D45180