[llvm] r328687 - [ORC] Fix ORC on platforms without indirection support.

Lang Hames via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 2 17:25:15 PDT 2018


Unfortunately the fix was to effectively revert the patch by returning to
the old condition. I have not had a chance to track down what went wrong on
the buildbots yet. :/

I think the missing piece, back when this was written, was the x86-64 Win32
ABI-compliant resolver block. That has since been implemented, but I recall
seeing Windows specific failures last time we turned this on. Unfortunately
I did not have access to a Windows machine to debug them.

If you have access to any machines that reproduce the failure I would be
happy to try to help you debug it.

-- Lang.

On Wed, Mar 28, 2018 at 9:12 AM, Andres Freund <andres at anarazel.de> wrote:

> Hi,
>
> On 2018-03-28 07:44:22 -0700, Lang Hames wrote:
> > That's ok. I missed that too. I will revert now and add a fix it if it
> has
> > not already been reverted.
>
> Thanks.  I see you pushed a fix.  On that note, what's the missing bits
> and pieces on windows? I'm interested in potentially fixing them. As
> much as I hate touching the platform (my permanent bane in postgres). It
> looks like there is relocation support?
>
> - Andres
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180402/f173befa/attachment.html>


More information about the llvm-commits mailing list