[lld] r329034 - Inline two trivial functions that are called only once. NFC.
Rui Ueyama via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 2 16:58:50 PDT 2018
Author: ruiu
Date: Mon Apr 2 16:58:50 2018
New Revision: 329034
URL: http://llvm.org/viewvc/llvm-project?rev=329034&view=rev
Log:
Inline two trivial functions that are called only once. NFC.
Modified:
lld/trunk/ELF/Symbols.cpp
lld/trunk/ELF/Symbols.h
Modified: lld/trunk/ELF/Symbols.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Symbols.cpp?rev=329034&r1=329033&r2=329034&view=diff
==============================================================================
--- lld/trunk/ELF/Symbols.cpp (original)
+++ lld/trunk/ELF/Symbols.cpp Mon Apr 2 16:58:50 2018
@@ -213,21 +213,18 @@ InputFile *Lazy::fetch() {
return cast<LazyObject>(this)->fetch();
}
-ArchiveFile &LazyArchive::getFile() { return *cast<ArchiveFile>(File); }
-
InputFile *LazyArchive::fetch() {
- std::pair<MemoryBufferRef, uint64_t> MBInfo = getFile().getMember(&Sym);
+ auto *F = cast<ArchiveFile>(File);
+ std::pair<MemoryBufferRef, uint64_t> MBInfo = F->getMember(&Sym);
// getMember returns an empty buffer if the member was already
// read from the library.
if (MBInfo.first.getBuffer().empty())
return nullptr;
- return createObjectFile(MBInfo.first, getFile().getName(), MBInfo.second);
+ return createObjectFile(MBInfo.first, F->getName(), MBInfo.second);
}
-LazyObjFile &LazyObject::getFile() { return *cast<LazyObjFile>(File); }
-
-InputFile *LazyObject::fetch() { return getFile().fetch(); }
+InputFile *LazyObject::fetch() { return cast<LazyObjFile>(File)->fetch(); }
uint8_t Symbol::computeBinding() const {
if (Config->Relocatable)
Modified: lld/trunk/ELF/Symbols.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Symbols.h?rev=329034&r1=329033&r2=329034&view=diff
==============================================================================
--- lld/trunk/ELF/Symbols.h (original)
+++ lld/trunk/ELF/Symbols.h Mon Apr 2 16:58:50 2018
@@ -283,7 +283,6 @@ public:
static bool classof(const Symbol *S) { return S->kind() == LazyArchiveKind; }
- ArchiveFile &getFile();
InputFile *fetch();
private:
@@ -299,7 +298,6 @@ public:
static bool classof(const Symbol *S) { return S->kind() == LazyObjectKind; }
- LazyObjFile &getFile();
InputFile *fetch();
};
More information about the llvm-commits
mailing list