[PATCH] D45158: [ELF] - X86_64: don't allow 8/16 bit dynamic relocations.

Rafael Avila de Espindola via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 2 16:42:08 PDT 2018

Previous message: [PATCH] D45158: [ELF] - X86_64: don't allow 8/16 bit dynamic relocations.
Next message: [PATCH] D45158: [ELF] - X86_64: don't allow 8/16 bit dynamic relocations.
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

espindola accepted this revision.
espindola added a comment.

LGTM

Two suggestion for followups:

Rename isPicRel. This is not really about being position independent, it is about the dynamic linker supporting these.
Use a while list instead.


https://reviews.llvm.org/D45158

Previous message: [PATCH] D45158: [ELF] - X86_64: don't allow 8/16 bit dynamic relocations.
Next message: [PATCH] D45158: [ELF] - X86_64: don't allow 8/16 bit dynamic relocations.
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the llvm-commits mailing list