[PATCH] D45180: libcalls must check for "RtLibUseGOT" metadata during simplification
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 2 13:21:12 PDT 2018
efriedma added inline comments.
================
Comment at: lib/Transforms/Utils/BuildLibCalls.cpp:991
if (File->getType()->isPointerTy())
- inferLibFuncAttributes(*M->getFunction("fputc"), *TLI);
+ inferLibFuncAttributes(*M->getFunction("fputc"), *TLI, M);
Char = B.CreateIntCast(Char, B.getInt32Ty(), /*isSigned*/true,
----------------
The "if (File->getType()->isPointerTy())" here is suspicious... I think we always need to honor the RtLibUseGOT metadata?
https://reviews.llvm.org/D45180
More information about the llvm-commits
mailing list