[PATCH] D44814: [CodeGenPrepare] Split huge basic blocks for faster compilation.

[Davide Italiano via Phabricator via llvm-commits]

davide added a comment.

I don't know how I feel about this patch. It looks like it's papering over a huge problem, which is basically the fact that some passes down the road are either quadratic or linear with large constant factor.
If we have examples of the broken passes, maybe we should consider whether it's feasible to fix them instead of applying this hack here?



================
Comment at: llvm/lib/CodeGen/CodeGenPrepare.cpp:218-221
+static cl::opt<unsigned> BasicBlockMaxSize(
+    "bb-max-size", cl::Hidden, cl::init(1000),
+    cl::desc("Split basic blocks bigger than this size when compiling for Os"));
+
----------------
How was this picked?


Repository:
  rL LLVM

https://reviews.llvm.org/D44814