[PATCH] D45080: [ELF] - Provide a hint about --no-check-sections

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

> In this message, I am saying "if you need overlays". That suggests that user *need* it. It is for cases like PR36768. LLD does not support OVERLAYS, though it is a possible legal thing to do.

As I said, if you show something, it suggests users do it even if the hint message comes with a footnote. You cannot really trust all users to understand what "if you need overlays" means. I think you can easily imagine that a user seeing that error message blindly adds that option to "fix" the problem. Unlike you, users are not linker experts, and our hint messages must be relevant to most users, or otherwise it could do harm than good.

Say, do you think that a half of the users who saw this hint message actually need `--no-check-sections`? I honestly don't think so. I cannot even imagine that 10% users who saw this error message have needed `--no-check-sections` because it is hard to imagine that you want to intentionally create overlapped sections.


https://reviews.llvm.org/D45080