[PATCH] D45130: Do not perform callsite splitting inside landing pad

[Jun Bum Lim via Phabricator via llvm-commits]

junbuml added inline comments.


================
Comment at: lib/Transforms/Scalar/CallSiteSplitting.cpp:486-487
         continue;
+      if (I->getParent()->isEHPad())
+        continue;
 
----------------
Can you move this check in canSplitCallSite()? You can use !CallSiteBB->isEHPad() instead of CallSiteBB->canSplitPredecessors() in line 216.



================
Comment at: test/Transforms/CallSiteSplitting/lpad.ll:1
+; RUN: opt -S -callsite-splitting < %s
+
----------------
Can you add FileCheck to check no callsite splitting happened ? 


Repository:
  rL LLVM

https://reviews.llvm.org/D45130