[llvm] r328950 - [AArch64] Reserve x18 register on Fuchsia

Petr Hosek via llvm-commits llvm-commits at lists.llvm.org
Sun Apr 1 16:44:04 PDT 2018


Author: phosek
Date: Sun Apr  1 16:44:04 2018
New Revision: 328950

URL: http://llvm.org/viewvc/llvm-project?rev=328950&view=rev
Log:
[AArch64] Reserve x18 register on Fuchsia

This register is reserved as a platform register on Fuchsia.

Differential Revision: https://reviews.llvm.org/D45105

Modified:
    llvm/trunk/lib/Target/AArch64/AArch64Subtarget.cpp
    llvm/trunk/test/CodeGen/AArch64/aarch64-named-reg-w18.ll
    llvm/trunk/test/CodeGen/AArch64/aarch64-named-reg-x18.ll
    llvm/trunk/test/CodeGen/AArch64/arm64-platform-reg.ll

Modified: llvm/trunk/lib/Target/AArch64/AArch64Subtarget.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AArch64/AArch64Subtarget.cpp?rev=328950&r1=328949&r2=328950&view=diff
==============================================================================
--- llvm/trunk/lib/Target/AArch64/AArch64Subtarget.cpp (original)
+++ llvm/trunk/lib/Target/AArch64/AArch64Subtarget.cpp Sun Apr  1 16:44:04 2018
@@ -151,8 +151,8 @@ AArch64Subtarget::AArch64Subtarget(const
                                    const std::string &FS,
                                    const TargetMachine &TM, bool LittleEndian)
     : AArch64GenSubtargetInfo(TT, CPU, FS),
-      ReserveX18(TT.isOSDarwin() || TT.isOSWindows()), IsLittle(LittleEndian),
-      TargetTriple(TT), FrameLowering(),
+      ReserveX18(TT.isOSDarwin() || TT.isOSFuchsia() || TT.isOSWindows()),
+      IsLittle(LittleEndian), TargetTriple(TT), FrameLowering(),
       InstrInfo(initializeSubtargetDependencies(FS, CPU)), TSInfo(),
       TLInfo(TM, *this) {
   CallLoweringInfo.reset(new AArch64CallLowering(*getTargetLowering()));

Modified: llvm/trunk/test/CodeGen/AArch64/aarch64-named-reg-w18.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/AArch64/aarch64-named-reg-w18.ll?rev=328950&r1=328949&r2=328950&view=diff
==============================================================================
--- llvm/trunk/test/CodeGen/AArch64/aarch64-named-reg-w18.ll (original)
+++ llvm/trunk/test/CodeGen/AArch64/aarch64-named-reg-w18.ll Sun Apr  1 16:44:04 2018
@@ -1,10 +1,8 @@
-; RUN: not llc -mtriple=aarch64-fuchsia -o - %s 2>&1 | FileCheck %s --check-prefix=ERROR
-; RUN: llc -mtriple=aarch64-fuchsia -mattr=+reserve-x18 -o - %s
+; RUN: llc -mtriple=aarch64-fuchsia -o - %s
 
 define void @set_w18(i32 %x) {
 entry:
 ; FIXME: Include an allocatable-specific error message
-; ERROR: Invalid register name "w18".
   tail call void @llvm.write_register.i32(metadata !0, i32 %x)
   ret void
 }

Modified: llvm/trunk/test/CodeGen/AArch64/aarch64-named-reg-x18.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/AArch64/aarch64-named-reg-x18.ll?rev=328950&r1=328949&r2=328950&view=diff
==============================================================================
--- llvm/trunk/test/CodeGen/AArch64/aarch64-named-reg-x18.ll (original)
+++ llvm/trunk/test/CodeGen/AArch64/aarch64-named-reg-x18.ll Sun Apr  1 16:44:04 2018
@@ -1,10 +1,8 @@
-; RUN: not llc -mtriple=aarch64-fuchsia -o - %s 2>&1 | FileCheck %s --check-prefix=ERROR
-; RUN: llc -mtriple=aarch64-fuchsia -mattr=+reserve-x18 -o - %s
+; RUN: llc -mtriple=aarch64-fuchsia -o - %s
 
 define void @set_x18(i64 %x) {
 entry:
 ; FIXME: Include an allocatable-specific error message
-; ERROR: Invalid register name "x18".
   tail call void @llvm.write_register.i64(metadata !0, i64 %x)
   ret void
 }

Modified: llvm/trunk/test/CodeGen/AArch64/arm64-platform-reg.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/AArch64/arm64-platform-reg.ll?rev=328950&r1=328949&r2=328950&view=diff
==============================================================================
--- llvm/trunk/test/CodeGen/AArch64/arm64-platform-reg.ll (original)
+++ llvm/trunk/test/CodeGen/AArch64/arm64-platform-reg.ll Sun Apr  1 16:44:04 2018
@@ -1,6 +1,7 @@
 ; RUN: llc -mtriple=arm64-apple-ios -mattr=+reserve-x18 -o - %s | FileCheck %s --check-prefix=CHECK-RESERVE-X18
 ; RUN: llc -mtriple=arm64-freebsd-gnu -mattr=+reserve-x18 -o - %s | FileCheck %s --check-prefix=CHECK-RESERVE-X18
 ; RUN: llc -mtriple=arm64-linux-gnu -o - %s | FileCheck %s
+; RUN: llc -mtriple=aarch64-fuchsia -o - %s | FileCheck %s --check-prefix=CHECK-RESERVE-X18
 ; RUN: llc -mtriple=aarch64-windows -o - %s | FileCheck %s --check-prefix=CHECK-RESERVE-X18
 
 ; x18 is reserved as a platform register on Darwin but not on other




More information about the llvm-commits mailing list