[PATCH] D45146: [x86] Introduce a pass to begin more systematically fixing PR36028 and similar issues.

Chandler Carruth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Apr 1 15:07:14 PDT 2018


chandlerc marked 2 inline comments as done.
chandlerc added a comment.

In https://reviews.llvm.org/D45146#1054076, @craig.topper wrote:

> I may go ahead and pull the X86InstrArithmetic.td changes out of this. The SchedRW is incomplete for ADCX, it needs a ReadAfterLd.


After talking on IRC, I've just landed this part of the patch. It's less broken and should make it easy for you to improve this stuff.

> Shoudl we pull out the X86InstrInfo.cpp changes too? Is this the same as the change in the spectre load hardening patch too?

Done.

Also, addressed the minor comments inline.


Repository:
  rL LLVM

https://reviews.llvm.org/D45146





More information about the llvm-commits mailing list