[PATCH] D45146: [x86] Introduce a pass to begin more systematically fixing PR36028 and similar issues.

[Craig Topper via Phabricator via llvm-commits]

craig.topper added a comment.

I may go ahead and pull the X86InstrArithmetic.td changes out of this. The SchedRW is incomplete for ADCX, it needs a ReadAfterLd.

Shoudl we pull out the X86InstrInfo.cpp changes too? Is this the same as the change in the spectre load hardening patch too?



================
Comment at: llvm/include/llvm/CodeGen/MachineBasicBlock.h:461
+  /// Copy a successor (and any probability info) from original block to this
+  /// block. Uses an iterator into the original blocks successors.
+  ///
----------------
block->block's


================
Comment at: llvm/lib/Target/X86/X86FlagsCopyLowering.cpp:144
+namespace {
+/// An enumeration of the aritmetic instruction mnemonics which have
+/// interesting flag semantics.
----------------
arithmetic*


Repository:
  rL LLVM

https://reviews.llvm.org/D45146