[llvm] r328926 - [X86] Remove unneeded temporary variable. NFC

[Craig Topper via llvm-commits]

Author: ctopper
Date: Sat Mar 31 23:29:21 2018
New Revision: 328926

URL: http://llvm.org/viewvc/llvm-project?rev=328926&view=rev
Log:
[X86] Remove unneeded temporary variable. NFC

This Promote flag was alwasys set to true except in the default case. But in the default case we don't need to set PVT and can just return false.

Modified:
    llvm/trunk/lib/Target/X86/X86ISelLowering.cpp

Modified: llvm/trunk/lib/Target/X86/X86ISelLowering.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86ISelLowering.cpp?rev=328926&r1=328925&r2=328926&view=diff
==============================================================================
--- llvm/trunk/lib/Target/X86/X86ISelLowering.cpp (original)
+++ llvm/trunk/lib/Target/X86/X86ISelLowering.cpp Sat Mar 31 23:29:21 2018
@@ -38717,14 +38717,12 @@ bool X86TargetLowering::IsDesirableToPro
   if (VT != MVT::i16)
     return false;
 
-  bool Promote = false;
   bool Commute = false;
   switch (Op.getOpcode()) {
-  default: break;
+  default: return false;
   case ISD::SIGN_EXTEND:
   case ISD::ZERO_EXTEND:
   case ISD::ANY_EXTEND:
-    Promote = true;
     break;
   case ISD::SHL:
   case ISD::SRL: {
@@ -38732,7 +38730,6 @@ bool X86TargetLowering::IsDesirableToPro
     // Look out for (store (shl (load), x)).
     if (MayFoldLoad(N0) && MayFoldIntoStore(Op))
       return false;
-    Promote = true;
     break;
   }
   case ISD::ADD:
@@ -38752,12 +38749,11 @@ bool X86TargetLowering::IsDesirableToPro
       return false;
     if (MayFoldLoad(N1) && (!isa<ConstantSDNode>(N0) || MayFoldIntoStore(Op)))
       return false;
-    Promote = true;
   }
   }
 
   PVT = MVT::i32;
-  return Promote;
+  return true;
 }
 
 bool X86TargetLowering::