[PATCH] D45108: [InstCombine] Get rid of select of bittest (PR36950 / PR17564)

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Mar 31 14:19:23 PDT 2018


lebedev.ri added inline comments.


================
Comment at: lib/Transforms/InstCombine/InstCombineSelect.cpp:1492
+      %3 = icmp eq i32 %2, 0
+      %S = lshr i32 %X, C     # C u< 32
+      %5 = and i32 %S, 1      # Mask B
----------------
Hmm, or should this be separated into two(?) different folds,
one to get rid of `lshr`, and another to get rid of `select` (i.e. the first ^ variant only, without `lshr`)?


Repository:
  rL LLVM

https://reviews.llvm.org/D45108





More information about the llvm-commits mailing list