[PATCH] D44847: [profile] Fix value profile runtime merging issues

[David Li via Phabricator via llvm-commits]

davidxl added inline comments.


================
Comment at: lib/profile/InstrProfilingMerge.c:40
 
+/* Returns the profile file size without value profiles.  */
+COMPILER_RT_VISIBILITY
----------------
xur wrote:
> davidxl wrote:
> > There is an existing interface for this:
> > 
> > __llvm_profile_get_size_for_buffer_internal
> using that API needs to pass the begin and end address for each section.
> Here we use all the counters recorded in the header.
Those pointers are available via __llvm_profile_begin_xxx /__llvm_profile_end_xxx.

It is better to avoid duplicating the logic of computing the profile data size.


https://reviews.llvm.org/D44847