[PATCH] D44847: [profile] Fix value profile runtime merging issues

[David Li via Phabricator via llvm-commits]

davidxl added inline comments.


================
Comment at: lib/profile/InstrProfilingValue.c:138
                                  uint32_t CounterIndex) {
+  __llvm_profile_instrument_target_value(TargetValue, Data, CounterIndex, 1);
+
----------------
Is this call getting inlined in the library build? If not, it will introduce unnecessary overhead.

One way to avoid this is to define a static always inline function, and then make the two APIs as wrappers to that common function.


https://reviews.llvm.org/D44847