[PATCH] D45098: [AArch64] fix PR32384: bump the number of stores per memset/memcpy/memmov

Sebastian Pop via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 30 13:36:01 PDT 2018


sebpop added a comment.

In https://reviews.llvm.org/D45098#1053266, @efriedma wrote:

> Looking at the generated code a bit, it looks like we do a really terrible job lowering memcpy; we don't form ldp/stp at all, ever.


Yes, the inline code for memcpy does not look great: I was seeing a mix of ldr and str.

> We should probably fix that before we mess with the threshold here; it could substantially change the codesize/performance impact of this change.

Agreed, let's measure the perf of this patch again after we improve the codegen for memcpy.


https://reviews.llvm.org/D45098





More information about the llvm-commits mailing list