[PATCH] D45098: [AArch64] fix PR32384: bump the number of stores per memset/memcpy/memmov

Evandro Menezes via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 30 11:43:08 PDT 2018


evandro added a comment.

In https://reviews.llvm.org/D45098#1053201, @efriedma wrote:

> Should we check for `hasNEON()` here?  The generic code doesn't know AArch64 has `ldp`/`stp`, so we might want to be a little more aggressive to compensate.


Makes sense.  Though `LDP` and `STP` are available to generic registers even when `hasNEON()` is false.   The issue is whether `AArch64LoadStoreOpt` can form the pairs if the pairs are too far apart.

Typically, depending on the target, blocks of loads and stores should be have the loads grouped together followed by the stores.


https://reviews.llvm.org/D45098





More information about the llvm-commits mailing list