[PATCH] D43242: [Coroutines] PR34897: Fix incorrect elisions

[Gor Nishanov via Phabricator via llvm-commits]

GorNishanov requested changes to this revision.
GorNishanov added a comment.
This revision now requires changes to proceed.

I believe that this check is too aggressive. It prevents http://godbolt.org/g/26viuZ from optimizing as well.
I think a distinction should be made for exceptional paths and happy path.
We need to make sure that we call coro.destroy on all happy paths.

I did not page-in everything I thought about the when_all_test bug, but, I scribbled somewhere this note about it: "Ignore coro.destroy on exceptional paths for the purpose of heap elision".


Repository:
  rL LLVM

https://reviews.llvm.org/D43242