[PATCH] D44978: Change DEBUG() macro to LLVM_DEBUG() in Polly
Michael Kruse via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 30 11:00:34 PDT 2018
Meinersbur added a comment.
Did you use the latest version of clang-format? Our unittests include a checking correct formatting and clang-format suggests the following changes:
--- C:/Users/Meinersbur/src/llvm/tools/polly/lib/CodeGen/PPCGCodeGeneration.cpp Fri Mar 30 11:50:07 2018
+++ - Wed Dec 31 18:00:00 1969
@@ -3409,8 +3409,8 @@
// Look for (<func-type>*) among operands of Inst
if (auto PtrTy = dyn_cast<PointerType>(Op->getType())) {
if (isa<FunctionType>(PtrTy->getElementType())) {
- LLVM_DEBUG(dbgs() << Inst
- << " has illegal use of function in kernel.\n");
+ LLVM_DEBUG(dbgs()
+ << Inst << " has illegal use of function in kernel.\n");
return true;
}
}
@@ -3489,8 +3489,8 @@
SplitBBTerm->setOperand(0, FalseI1);
LLVM_DEBUG(dbgs() << "preloading invariant loads failed in function: " +
- S->getFunction().getName() + " | Scop Region: " +
- S->getNameStr());
+ S->getFunction().getName() +
+ " | Scop Region: " + S->getNameStr());
// adjust the dominator tree accordingly.
auto *ExitingBlock = StartBlock->getUniqueSuccessor();
assert(ExitingBlock);
You can run `ninja polly-update-format` to apply automatically fix the formatting.
LLVM patch has not yet landed, so I did not test whether it compiles.
Otherwise, LGTM.
Repository:
rPLO Polly
https://reviews.llvm.org/D44978
More information about the llvm-commits
mailing list