[PATCH] D45062: [ThinLTO] Add an option to force summary call edges cold for debugging

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added inline comments.


================
Comment at: lib/Analysis/ModuleSummaryAnalysis.cpp:331
     CallGraphEdges[Index.getOrInsertValueInfo(I)].updateHotness(
-        CalleeInfo::HotnessType::Critical);
+        ForceSummaryEdgesCold ? CalleeInfo::HotnessType::Cold
+                              : CalleeInfo::HotnessType::Critical);
----------------
eraman wrote:
> Is this the desired behavior or should the flag not affect these edges that are forced to be inlined in AutoFDO? One can argue for preserving critical edges so that the profile gets applied correctly. If you think this behavior is desired, please mention this in the description text of the flag.
I think both options are potentially useful, so I have changed this to an enum so that we can support both.


Repository:
  rL LLVM

https://reviews.llvm.org/D45062